No troubadour/valkyrie love so far in this thread.
Most Favorite: Troubadours, valkyries, and the pegasus knight line. I tend to love the troubadour and valkyrie(bad guys included) characters whether its by design or by their character. Also, in an actual war I'd rather avoid stabbing and chopping someone up. I'd personally prefer riding on horseback and healing or perhaps zapping enemies with magic.
Pegasus knights because of their unrivaled utility especially in early game . I don't know how I'd keep those hostage villagers or low health allies safe without them.
Least Favorites: I'd have to say knights but I'm only referring to knight and generals. I like great knights. Also the first class axe-wielder classes except the wyvern riders. These two classes I don't tend to use most probably since I tend to prioritize leveling up the main lord and they lose in terms of movement to cavaliers so they end up weaker causing me to just bench them when I get more magic users.